Skip to content

[DOC]✨ feat(milvus): add Milvus deployment into Kubernetes and semantic cache support#773

Merged
rootfs merged 2 commits intovllm-project:mainfrom
samzong:docs/milvus-kubernetes
Dec 11, 2025
Merged

[DOC]✨ feat(milvus): add Milvus deployment into Kubernetes and semantic cache support#773
rootfs merged 2 commits intovllm-project:mainfrom
samzong:docs/milvus-kubernetes

Conversation

@samzong
Copy link
Copy Markdown
Collaborator

@samzong samzong commented Dec 4, 2025 •
edited
Loading

Related Issue

Partially #280

What's included

  • Milvus deployment configs (Helm + Operator)
  • Configuration management (ConfigMap, Secret, NetworkPolicy)
  • Monitoring integration (ServiceMonitor)
  • Comprehensive documentation (installation, migration, backup, troubleshooting)

Future work (out of scope for this PR)

  • Grafana dashboard for semantic cache metrics
  • Cloud-specific deployment guides (EKS/GKE/AKS)
  • Performance tuning guidelines

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 4, 2025 •
edited
Loading

✅ Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit e9a2d96
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/6938b36ddbc0460008d8dcc6
😎 Deploy Preview https://deploy-preview-773--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 4, 2025 •
edited
Loading

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 tools

Owners: @yuluo-yx, @rootfs, @Xunzhuo
Files changed:

  • tools/milvus/README.md
  • tools/milvus/test-milvus-deployment.sh

📁 website

Owners: @Xunzhuo, @rootfs, @yuluo-yx
Files changed:

  • website/docs/installation/milvus.md
  • website/docs/tutorials/semantic-cache/hybrid-cache.md
  • website/docs/tutorials/semantic-cache/milvus-cache.md
  • website/sidebars.ts
vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

@samzong samzong force-pushed the docs/milvus-kubernetes branch 2 times, most recently from b11c661 to fb1c8b2 Compare December 5, 2025 00:49
@samzong
✨ docs(milvus): add milvus helm install and semantic cache config
6e40b71 
Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong samzong force-pushed the docs/milvus-kubernetes branch from fb1c8b2 to 6e40b71 Compare December 5, 2025 03:47
@samzong
Copy link
Copy Markdown
Collaborator Author

samzong commented Dec 5, 2025

/gemini summary

@samzong samzong requested a review from Copilot December 5, 2025 03:49
@samzong samzong marked this pull request as ready for review December 5, 2025 03:49
Copilot AI reviewed Dec 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@samzong samzong requested a review from Copilot December 5, 2025 09:41
Copilot AI reviewed Dec 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@rootfs
Copy link
Copy Markdown
Collaborator

rootfs commented Dec 6, 2025

@JackLCL can you review the Milvus setup? Thanks

@JackLCL
Copy link
Copy Markdown
Contributor

JackLCL commented Dec 8, 2025

@JackLCL can you review the Milvus setup? Thanks

looks good to me

@rootfs
Copy link
Copy Markdown
Collaborator

rootfs commented Dec 8, 2025

@JackLCL thanks!

@rootfs
Copy link
Copy Markdown
Collaborator

rootfs commented Dec 8, 2025

@samzong is it ready to go?

@samzong
Copy link
Copy Markdown
Collaborator Author

samzong commented Dec 8, 2025

@rootfs Yes， it's ready for merge. I forgot change the title.

@samzong samzong changed the title [do-not-merge] [DOC]✨ feat(milvus): add Milvus deployment into Kubernetes and semantic cache support [DOC]✨ feat(milvus): add Milvus deployment into Kubernetes and semantic cache support Dec 8, 2025
@rootfs
Copy link
Copy Markdown
Collaborator

rootfs commented Dec 8, 2025

@samzong just a precommit error before merge :D

@samzong
docs(milvus): improve troubleshooting section and monitoring script
e9a2d96 
Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong samzong force-pushed the docs/milvus-kubernetes branch from 983f267 to e9a2d96 Compare December 9, 2025 23:40
@samzong
Copy link
Copy Markdown
Collaborator Author

samzong commented Dec 11, 2025 •
edited
Loading

@rootfs it's ready. all test is passed.

@rootfs rootfs merged commit 2894498 into vllm-project:main Dec 11, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo Xunzhuo is a code owner

@rootfs rootfs Awaiting requested review from rootfs rootfs is a code owner

+1 more reviewer

@yuluo-yx yuluo-yx yuluo-yx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rootfs rootfs

@Xunzhuo Xunzhuo

@yuluo-yx yuluo-yx

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@samzong @rootfs @JackLCL @yuluo-yx @Xunzhuo